claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes
https://claudiajs.com/claudia-bot-builder.html
MIT License
1.84k stars 253 forks source link

Adding support to Cortana and Google Home #116

Open carloseduardole opened 6 years ago

carloseduardole commented 6 years ago

Hello,

I would like to contribute with a plugin for Cortana and Google Home.

This implementation relies on the 3rd party libs distributed by Cortana and google to their assistants.

stojanovic commented 6 years ago

Awesome, I'll take a look at it!

We still try to be compatible with Node v4 (which is probably not that important anymore, but I need to discuss support with other team members), and the tests are failing because you used:

const { ActionsSdkApp } = require('actions-on-google');

As this is a simple change, can you make sure it works on node 4, too?

carloseduardole commented 6 years ago

@stojanovic, I was doing some tests with node 4 yesterday, and the problem is that actions-on-google support just node 6+.

"engines": { "node": ">=6.0.0" },

So it will be hard to add support to node 4.

carloseduardole commented 6 years ago

@stojanovic it seems that node 4 support is ending https://medium.com/the-node-js-collection/april-2018-release-updates-from-the-node-js-project-71687e1f7742

gojko commented 6 years ago

I planned to clean up some code in claudia anyway when 4 goes away, but until it's fully gone in end of july, we should support it with claudia tools.

I suggest we use a major version (eg 5) and drop node4 support from it. then this gets integrated only into v5. people who are still on node4 can use claudia v4/claudia bot builder v4

gojko commented 6 years ago

I've pushed claudia 5.x to NPM, which now assumes Node 6 as the baseline, so we can unblock this finally. Things that are only supported in 6 can now go into the main toolkit.

acucciniello commented 5 years ago

any update when this will be complete? I am looking to use the bot builder for a multitude of bots! including alexa and google home

carloseduardole commented 5 years ago

I will try to update this branch with the latest changes from claudia-bot-builder this week to see if the problem with Node Version is solved.

carloseduardole commented 5 years ago

Ok, commit rebased with the master. Waiting on the review now ;)