Add Function for Adding a Video From Attachment ID

claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes

https://claudiajs.com/claudia-bot-builder.html

MIT License

1.84k stars 253 forks source link

Add Function for Adding a Video From Attachment ID #123

Open acucciniello opened 5 years ago

acucciniello commented 5 years ago

- facebook allows for you to upload a file and serve it from them
- this function allows you to use a video from an attachment rather than trying to upload it from where ever it is hosted
- this could save load times for all videos being served

stojanovic commented 5 years ago

Thanks and sorry for the late reply. I'll test this during the weekend and merge it.

stojanovic commented 5 years ago

@acucciniello looks good, but can you add a test for this? If you don't know how to do that I can help.

acucciniello commented 5 years ago

@stojanovic Sorry for the massive delay, I am just getting back to this. What are some tests you would need to make?

acucciniello commented 5 years ago

@stojanovic In order to get an attachment id, I need to call the facebook API with a page access token. Without that I cannot make an image or a video. Do you have a page access token that works for testing?

stojanovic commented 5 years ago

Sorry for the late reply. No need to invoke the Facebook API from the tests, let's just add a simple unit tests to make sure that we don't break this functionality in future. For example, invoke the video template and confirm that JSON structure is what you expect it to be. Also, try to invoke it without an attachment ID and check if the error is expected.