Closed nbransby closed 7 years ago
I looked at adding a test for this one but its actually quite tricky to implement - I thought I would get this PR in first as its currently broken
It's not tricky, just check that json in the end doesn't have notification_type
property.
Which spec is doing something similar so I can see an example?
Something like this, just notification_type
in message and make sure it doesn't exists in message.
Merging it right now and I'll add the test later today and publish new version.
Sorry chaps didnt get a chance write the test - let me know if you still need me to do it
It would be good if you could also add an automated test for this before merging, so we can make sure not to break this functionality when someone else is modifying the code in the future.