search

claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes
https://claudiajs.com/claudia-bot-builder.html
MIT License
1.84k stars 252 forks source link

Fix warning returned by send api due to extranous property in request json #86

Closed nbransby closed 7 years ago

gojko commented 7 years ago

It would be good if you could also add an automated test for this before merging, so we can make sure not to break this functionality when someone else is modifying the code in the future.

nbransby commented 7 years ago

I looked at adding a test for this one but its actually quite tricky to implement - I thought I would get this PR in first as its currently broken

stojanovic commented 7 years ago

It's not tricky, just check that json in the end doesn't have notification_type property.

nbransby commented 7 years ago

Which spec is doing something similar so I can see an example?

stojanovic commented 7 years ago

Something like this, just notification_type in message and make sure it doesn't exists in message.

stojanovic commented 7 years ago

Merging it right now and I'll add the test later today and publish new version.

nbransby commented 7 years ago

Sorry chaps didnt get a chance write the test - let me know if you still need me to do it