search

claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes
https://claudiajs.com/claudia-bot-builder.html
MIT License
1.84k stars 253 forks source link

Handle incoming MMS from Twilio #97

Closed jonjamz closed 7 years ago

jonjamz commented 7 years ago

This update adds a media key to the parsed object that contains an array of objects with url and contentType keys for each MMS media attachment.

It updates the conditional checks to support messages with no body text as long as media is present.

I tested it on a deployed bot by inspecting the CloudWatch logs.

stojanovic commented 7 years ago

Thanks. Can you add some tests for this? This file should be a good destination for those tests: https://github.com/claudiajs/claudia-bot-builder/blob/master/spec/twilio/twilio-parse-spec.js

jonjamz commented 7 years ago

Yes certainly, I was actually just going through those.

stojanovic commented 7 years ago

Awesome, thanks

jonjamz commented 7 years ago

If you have any ideas for further tests just let me know and I'll add them.

stojanovic commented 7 years ago

Looks good, new build will be published during the weekend. Thanks!