catch messaging_referrals in fb/parse

claudiajs / claudia-bot-builder

Create chat bots for Facebook Messenger, Slack, Amazon Alexa, Skype, Telegram, Viber, Line, GroupMe, Kik and Twilio and deploy to AWS Lambda in minutes

https://claudiajs.com/claudia-bot-builder.html

MIT License

1.84k stars 253 forks source link

catch messaging_referrals in fb/parse #99

Closed yipcma closed 7 years ago

yipcma commented 7 years ago

this branch is edited from tag v2.15 intended to catch fb/messaging_referrals.

it catches all types of referrals, and put referral.ref in request.text when possible
it adds a referral boolean
it is placed ahead of other condition checks to not get hidden

Thank you very much for the wonderful and hackable project :)

gojko commented 7 years ago

hi, thanks for this - can you please add some examples of referral messages and correct parsing to https://github.com/claudiajs/claudia-bot-builder/blob/master/spec/facebook/facebook-parse-spec.js, so future changes don't break your code?

yipcma commented 7 years ago

Sure thing @gojko, am new to testing, any best references you would point me to so I can get up to speed? I want to do testing for my nodejs code for a long time, just not sure where best to start.

gojko commented 7 years ago

@yipcma check out https://github.com/claudiajs/claudia-bot-builder/blob/master/CONTRIBUTING.md#running-tests for how to run tests, and then I guess reading existing tests for the bot builder is a good start. Check out https://jasmine.github.io/ for info on the testing automation tool we use

gojko commented 7 years ago

I'm closing this due to inactivity. If someone wants to pick this up, please re-open the pull request or submit a new one