search

claudiajs / claudia

Deploy Node.js projects to AWS Lambda and API Gateway easily
https://claudiajs.com
MIT License
3.8k stars 276 forks source link

Add default value for resultTtl #167

Closed sartios closed 5 years ago

gojko commented 6 years ago

this changes backwards compatibility, so it's not OK to merge it. it would be better to use explicit value of 0 if you want to use zero. Amazon's default is not zero, from what I understand, so keeping this in line with AWS defaults is important, especially because lots of people already use it like that.

sartios commented 6 years ago

AWS defaults for this value is 300 seconds according to this link

I'm going to add the default value of 300 sec to params and update to conditional to check whether is undefined.

gojko commented 6 years ago

@sartios Thanks! this looks good - I added a few comments, but after that i'm happy to merge.

gojko commented 5 years ago

thanks, this is now on NPM as 5.1.2