claudiajs / claudia

Deploy Node.js projects to AWS Lambda and API Gateway easily
https://claudiajs.com
MIT License
3.8k stars 274 forks source link

claudia create/update should work well with patch-package #170

Closed ceefour closed 6 years ago

ceefour commented 6 years ago

patch-package is very useful for forking/fixing a problem in the meantime before official bugfix.


  1. npm install --save patch-package
  2. edit a file e.g. node_modules/aws-serverless-express/express/src/index.js even adding comment will do
  3. npx patch-package aws-serverless-express
  4. claudia create --keep ...
ceefour commented 6 years ago

Workaround from @stojanovic :

you can use --use-local-dependencies option in Claudia and deploy whatever you have in your local node_modules, or simply fork a repo and fix the issue, just install the module from your fork, not from NPM.

gojko commented 6 years ago

@ceefour one of the goals of Claudia is not to introduce too much magic, so we use NPM for package management. local dependencies are the right way to solve it, not a workaround, so I’ll close this issue.