search

claudiatebaldi / hectorcal

3 stars 3 forks source link

Update package data #32

Closed rplzzz closed 4 years ago

rplzzz commented 4 years ago

Bring the package datasets up to date with the new ESM data. This includes updating the PCA code to deal with variables being available over different sets of years.

kdorheim commented 4 years ago

@claudiatebaldi it looks like this PR that contains the good comparison data (without NAs). I am slightly conflicted because it looks like this PR contains a lot of changes... which scares me a tad bit. An alternative would be to open another branch and only add the changes that correspond to the new comparison data. What do you think?

rplzzz commented 4 years ago

@claudiatebaldi Do me a favor, and make sure we don't delete this branch. It looks like this PR was merged as a squash-commit, so in the master branch we can't see the individual changes that went into it, but they still exist on this branch. Having access to that history may be useful in tracking down the problems that you are seeing.