search

claudiiafg / MapConU

Concordia Campus Navigation App - Indoor and Outdoor directions integrated with Google Calendar
7 stars 2 forks source link

Feature/indoor poi #278

Closed GwenLegate closed 4 years ago

GwenLegate commented 4 years ago

Created indoor pois by adding markers to all of the floor plans and setting them to be visible or invisible according to the toggles.

GwenLegate commented 4 years ago

I forgot we talked about directions implementation. Except for the emergency exits in jmsb (I added 3 that don't already have existing points), I think all the directions functionality should already be there so it shouldn't be too hard to implement but I'm not sure if I can figure it out. We need a bit more code documentation. Probably both the indoor and outdoor code need some documentation and refactoring to make them easier to follow.

I think another issue with poi directions is it's essentially the same functionality as indoor directions. We don't have a gps location indoors so we'd need to let the user select a start point There is more than 1 possible end point since there is usually more than 1 poi per category

The easiest way to do that is to trigger an indoor directions popover with destination points filtered to just the pois which is probably a redundant feature

GwenLegate commented 4 years ago

Functionality and code looks good. Same comments as Alec about the icons.

Also, can you try doing 1024 - x and 1024 - y for x, y in the 9th floor ? That might fix the positioning of the POIs.

Oh! I'm looking at where the markers are vs where the indoor directions shows the directions to and I think you're right. If (0,0) was on the bottom right the icons would probably be in the right place

GwenLegate commented 4 years ago

Functionality and code looks good. Same comments as Alec about the icons. Also, can you try doing 1024 - x and 1024 - y for x, y in the 9th floor ? That might fix the positioning of the POIs.

Oh! I'm looking at where the markers are vs where the indoor directions shows the directions to and I think you're right. If (0,0) was on the bottom right the icons would probably be in the right place

Update, It didn't work, it made the poi's more crazy. I also figured out that the 9th floor random marker is the marker that should only show up when the path directions are computed but my quick fix of setting it to visibility: hidden makes it disappear and never reappear.

The only thing I can think of to do is to look and where the directions point for these pois and set them manually. That's not going to be a quick job though.

GwenLegate commented 4 years ago

Changed the poi's that were off by comparing their positions to the directions path endpoint and updating their coordinates manually. Did a rebase after code merged to master yesterday so it should be good to merge into master.

While I was bug checking I realized that an additional directions feature to the poi probably isn't necessary. The feature where you click on he indoor map and are able to get directions to the point you click on is essentially the same thing. If you toggle the poi you want on it just indicates the point you want on the map, if you want directions, just click that location on the map.