claudiiafg / MapConU

Concordia Campus Navigation App - Indoor and Outdoor directions integrated with Google Calendar
7 stars 2 forks source link

Bugfix/sonar qube issues #309

Closed GwenLegate closed 4 years ago

GwenLegate commented 4 years ago

Some minor bugs identified in the SonarQube report fixed. Here is a summary of changes made:

There were no major refactoring necessary

google-map.component.ts -removed unused Buildinginfo import -removed useless assignment to variable 'result' in showAlert(building, address) method

room-selector-popover.component.html
-removed commented code for readability

calendar.component.ts
-removed unused import statements HttpErrorResponse and CatchError
-removed assignment to room = 'mb1-210' in return statement and just returned 'mb1-210'

translation.service.ts
-empty if statement in subscribeToAppLanguage(currentLanguage) method should not have been empty!

outdoor-view.page.ts
-removed unused import ElementRef

h8.component.html -removed commented out code