Fixes GitHub auth with a new config param

claudioc / jingo

Node.js based Wiki

MIT License

1.02k stars 184 forks source link

Fixes GitHub auth with a new config param #105

Closed aruizca closed 8 years ago

aruizca commented 8 years ago

introduces authentication.github.callbackUrl parameter for GitHub authentication. This way server.baseUrl is not used anymore for real.

Related to issue #104

Cheers!

claudioc commented 8 years ago

Hi,

thank you for the submission. I need to take a moment to think about it before merging, but apparently it's OK :)

aruizca commented 8 years ago

It also retrieves jQuery using https instead of http. To avoid security problems when serving the wiki under https

aruizca commented 8 years ago

I am going to close this PR as I have effectively forked this repo with quite a few new features. I will provide a full PR when finished, but I doubt it will ever get merged