validMatches is not working for Github login

claudioc / jingo

Node.js based Wiki

MIT License

1.02k stars 184 forks source link

Closed jpkli closed 8 years ago

jpkli commented 8 years ago

Using validMatches to restrict user emails is not working.

claudioc commented 8 years ago

Is it possible that the user has an empty email?

I've added (as for Jingo 1.5.0) a new emptyEmailMatches authorization parameter. Set it to false so that the user won't validate.

jpkli commented 8 years ago

Actually, the user has multiple linked emails seems to have problem. User with one email is okay.

claudioc commented 8 years ago

Hi,

yes, this problem has already been raised some time ago and there is nothing much I can do. Maybe I should write it down in the README.