search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 184 forks source link

Generate Table of Contents #112

Closed BradlySharpe closed 8 years ago

BradlySharpe commented 8 years ago

Automatically generate a table of contents on the page using [(TOC)].

This will find all heading tags h2 to h6 and create a table of contents. h1 is usually the page heading so it is ignored.

claudioc commented 8 years ago

Hey @brad7928, nice work! I will take a more deep look at and eventually I will merge your PRs during the week end. I have a really hard time at work right now (looong evenings...).

Thank you very much!

BradlySharpe commented 8 years ago

Hi @claudioc, have you had any luck looking at these?

Thanks, Brad

claudioc commented 8 years ago

@brad7928 no, not yet. The thing is that your PRs are closing a couple of the most requested issues and for this reason I don't want to rush into them and take a careful look at them.

Don't worry, I am just very tired: my daily job is really crazy due to the things we need to close in December but I will merge them eventually.

BradlySharpe commented 8 years ago

No worries, thanks! More than happy to look at some of the other issues if needed?

claudioc commented 8 years ago

OK, this is funny: can you take a look at this PR (it just came in)? https://github.com/claudioc/jingo/pull/115/

Apparently there is a markdown-toc module I didn't know about. Did you? :)

BradlySharpe commented 8 years ago

That looks nice! I didn't know that module existed. I think it would be better off going with #115 as it will provide the ability to add other directives in the future.

I think there is an issue with it at the moment though, will comment on that PR.

claudioc commented 8 years ago

Closed because of #115