search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 184 forks source link

Ability to add heading fragments #119

Closed BradlySharpe closed 8 years ago

BradlySharpe commented 8 years ago

Fixes issue #13.

Not sure if there may be a better way of doing this. The problem is the regex for the headings expects the heading to be on a line by itself.

claudioc commented 8 years ago

Sorry, I had to revert this one because I doesn't work very well: when you create an headerFragment the html rendering below gets strange (it has something to do with :before element or the icon...). Try adding two or three H one after the other: it seems like the second one get moved to the right

BradlySharpe commented 8 years ago

Will give it a go now, I thought I had tested that one.

I was going to do if (!something) { return; } but thought this provides better readability and less lines. Happy to change it though.