search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 183 forks source link

Introduce OpenSteetMap via OAuth2 #163

Closed TheFive closed 4 years ago

TheFive commented 8 years ago

This Pull Request introduces OpenStreetMap Authorization via OAuth2.

OpenStreetMap is not supporting any email fields, so you have to ignore email to use, this is documented in the Readme.

Other parts of this pull request:

a) disabled CookieSession

cookie-session and express-session are doing similar things (http://stackoverflow.com/questions/15744897/what-is-the-difference-between-session-and-cookiesession-middleware-in-conne) and i had trouble using the OpenStreetMap OAuth mechanism with CookieSession enabled, so i just have commented it out.

b) Introduced OpenStreetMap related staff, similar to Google or GitHub OAuth.

All test are still running.

TheFive commented 8 years ago

May be you "require" the OpenStreetMap Strategy in the configuring if clause, not do require all possible strategy static, but doing that dynamic.

claudioc commented 8 years ago

Hi,

unfortunately Jingo authentication system is not very "pluggable", and it probably should be (since a lot of PR are related to the implementation of an authentication system). Adding your code to the master branch would be a little too much – I believe (like the presence of the SQL there). I will definitely look at this PR once I will start working on version 2 (which will be much more pluggable and not a monolith like it is right now).

I will leave it OPEN anyway for a while :)

Thank you very much for your work!