search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 184 forks source link

Fixes missing dev dependency "nodemon" #171

Closed JSteunou closed 7 years ago

derhuerst commented 7 years ago

Maybe a peer dependency?

JSteunou commented 7 years ago

nope. It really is a dev dependency.

derhuerst commented 7 years ago

Hm. I'd be in favor of making it a peer dependency, as it's clearly not needed for running tests, linting, etc. Also, for daemonizing, some people prefer different tools like forever or pm2.

JSteunou commented 7 years ago

I assume as it is in npm scripts it is a dev dependency. Why you could run npm test but not npm start-dev after a fresh install?

derhuerst commented 7 years ago

That's a valid point. But testing is clearly a thing that should be possible with the devDependencies installed, whereas daemonizing should imho not be part of npm scripts and therefore not in the devDependencies. But that's just my two cents.

claudioc commented 7 years ago

I think @JSteunou is right. If there is a start-dev which uses nodemon, there should also be nodemon in the devDependencies.