search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 183 forks source link

File Upload Support #176

Open scristall opened 7 years ago

scristall commented 7 years ago

This pull request is the File Upload work done by czenzel (noted in issue https://github.com/claudioc/jingo/issues/98) updated to latest and with minor additions.

It offers a simplistic dialog in the edit page for uploading a file to /repo/uploads which can then be linked to or served by other pages. This greatly simplifies the addition of images to the wiki.

claudioc commented 7 years ago

Hi and thanks for the effort!

I am not going to merge this one in the master branch, though, for the same concerns I have and detailed in #98

I will leave the PR open anyway for future reference.

scristall commented 7 years ago

Hi @claudioc!

What would the PR need for you to consider merging it in? I'm happy to maintain the fork, but I feel it's a valuable feature and wouldn't mind doing the work if you have a straight forward guideline. I know you discussed a file manager, which is probably doable in a simplistic sense.

claudioc commented 7 years ago

Hey,

my biggest problem with this feature is that I'd need to maintain such a (big) one in the main branch and I'd really prefer not to. I recently accepted quite a big PR for LDAP support and – guess what? – now people are opening issues on that feature and I am not able to fix them, probably. If I want to maintain control of Jingo I must keep it "small"

I still think that the file upload feature is off-topic to Jingo, because Jingo doesn't want to be a full fledged CMS but a viewer with editing capabilities. Adding file upload would open a whole lot of problems (I already see someone asking for S3 or Dropbox support).