search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 183 forks source link

Support emojis #187

Open shinzui opened 7 years ago

shinzui commented 7 years ago

Marked currently does not support emojis and they've had the related issue open for three years now. I suggest switching to another library such as markdown-it.

Marked does not appear to be well maintained based on the number of outstanding issues and pull requests so switching has other benefits.

claudioc commented 7 years ago

I will take a look into this, it's a good point.

I believe I'd need to support both of them for a while to be sure I am not breaking anything (I cannot obviously test that markdown-it would work without any issue with ALL the existing Jingo installations).

Thanks!

FranklinYu commented 6 years ago

Switching to markdown-it will break something because many fixes are "breaking fix". I think it is safer to do the switch in next major version of Jingo.

Also: https://softwareengineering.stackexchange.com/questions/368030/is-a-breaking-change-bug-fix-a-semver-patch-or-a-major

claudioc commented 6 years ago

@franklinyu that's what I am doing indeed :)