claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 184 forks source link

Update LDAP authentication to support binding with user credentials #212

Closed ScreamingHawk closed 7 years ago

ScreamingHawk commented 7 years ago

It's common practice to anonymous binding for LDAP authentication, however the current implementation does not allow enough variance for passing through the user credentials.

This change allows the bindDn and bindAuthentication variables to use the same {{x}} substitution used by the searchFilter further upstream. This method also exposes the username and password fields for easy modification if required by particular non-standard implementations.

When not used, there are no changes to existing functionality.