search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 185 forks source link

application.proxyPath doesn't "work correctly"? #242

Open jandrieu opened 6 years ago

jandrieu commented 6 years ago

In the reference documentation, we have:

application.proxyPath (string: "")

If you want jingo to work "behind" another website (for example in a /wiki directory of an already existing intranet), you need to configure it to be aware of that situation so that it can write all the outbound URLs accordingly. Use this option to pass it the name of the directory that you've configured in your proxy_pass option in nginx or apache. See also an nginx example in the /etc directory of the jingo source distribution.

Please note that jingo won't work correctly if this option is activated.

What does it mean that jingo won't work correctly with this option? Why have it if it doesn't work correctly?

claudioc commented 5 years ago

Hi @jandrieu

I think I wrote that (silly) note as a disclaimer to avoid having to deal with weird and complex setups that people may put in place (I am the only maintainer/developer of the project and I need to keep things as simple as possible). I think that over time I haven't received any issues about it and we now also have a couple of a pages in this wiki (https://github.com/claudioc/jingo/wiki) explaining more in details how to setup a reverse proxy with Jingo.

Thanks! (I will flag this as a bug and remove the note with the next release)