claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 185 forks source link

page name with colon cause search result wrong #263

Closed GHolk closed 4 years ago

GHolk commented 4 years ago

i am trying to use colon or slash as namespace sepatator. the slash / is replaced by + on filesystem, and colon is keeped, but in search result, the filename after colon is interpreted as line number from the result of git grep (in lib/gitmech.js) . thus render wrong result.

claudioc commented 4 years ago

Hey @GHolk can you please give me an example of some page names that show this behaviour? Thanks!

GHolk commented 4 years ago

the page with colon in name: https://lab.gholk.ml/jingo/wiki/test:name-with-colon

display wrong in search result: https://lab.gholk.ml/jingo/search?term=name-with-colon

claudioc commented 4 years ago

Thank you, fixed (check the commit to see how, if you want) :D