claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 185 forks source link

Null-line terminator to support non-latin chars #266

Closed mivort closed 4 years ago

mivort commented 4 years ago

I've had an issue with non-latin wiki page titles. Default behaviour of git-ls-tree seems to replace certain characters with escape sequences, so it can use \n as item breaks safely. It has an option (-z) to use \0 as item separator instead of line-breaks. In that mode it doesn't replace characters.

Here's screenshot how it looks in page listing:


nonlatin


With addition of -z option characters are not getting replaced by git and links to pages and commit info are become properly displayed.

claudioc commented 4 years ago

Hey, nice catch – thanks!