search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 184 forks source link

Feature/reverse proxy #61

Closed almereyda closed 9 years ago

almereyda commented 9 years ago

To be done:

As you can see below, this PR includes two changes:

We should discuss first before merging, because I believe both commits have their quirks that we have to evaluate first:

  1. Why was baseUrl prepared in the code, but not used?
  2. Why has it been that this.remote and this.branch have been undefined before this change?

Next PR: Persona :). (But not today.)

Note: I'm using this in production on http://wiki.transformap.co.

claudioc commented 9 years ago

Oh, I don't remember why I removed baseUrl. Probably because I realised that that could have been inferred?

almereyda commented 9 years ago

Probably because I realised that that could have been inferred?

Well, sounds reasonable, but just not in a reverse proxied environment ;) .

@claudioc Would you like to have a clear commit log or can I move forward just commiting right away? Just in case you care about the git log.

Also, what to do with the malicious inferring taking place? Maybe I should move the git commit into another branch?

claudioc commented 9 years ago

@almereyda I just committed some of the changes on this PR plus a fix for the bug in gitmech, plus an updated module list. Take a look at https://github.com/claudioc/jingo/commit/f565a35015f04a35eeec3d4a2dc81d1bff22b1ae

I also mentioned you in the ChangeLog, hope you don't mind :)

almereyda commented 9 years ago

Well, that's fine then. I may not be in the commit log, but as all this stuff is so virtual ... close.

claudioc commented 9 years ago

No, this is not fine. I didn't think about the commit name, sorry.

Feel free to issue a PR on the AUTHORS file with your name in it and I will merge it.