search

claudioc / jingo

Node.js based Wiki
MIT License
1.02k stars 182 forks source link

Tables #68

Closed almereyda closed 9 years ago

almereyda commented 9 years ago

The current implementation of Tables does not work exaclty.

Also the document's CSS could be improved for clarity.

claudioc commented 9 years ago

Hi,

what to you mean my "improve the document CSS"?

scordature commented 9 years ago

This should appear as a table, correct?

foo | bar
----| ----
syn | ack
one | two

In my test page it does not appear as a table.

The backticks above are just for clarity. I don't use them in my test page.

http://jingo.cica.li:6067/wiki/And-we-will-all-the-pleasures-prove

claudioc commented 9 years ago

For sure what was missing was the CSS support for tables (oops). But the markdown support was there already (from marked). It just seems tables are very sensitive on how you create them with markup.

Look now http://jingo.cica.li:6067/wiki/And-we-will-all-the-pleasures-prove

https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#tables

scordature commented 9 years ago

thanks, Claudio, this is great!

On Sat, Oct 17, 2015 at 2:29 AM, Claudio Cicali notifications@github.com wrote:

For sure what was missing was the CSS support to tables (oops). But the markdown support was there already (from marked). It just seems tables are very sensitive on how you create them with markup.

https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#tables

— Reply to this email directly or view it on GitHub https://github.com/claudioc/jingo/issues/68#issuecomment-148898717.