Closed vschoettke closed 9 years ago
Hi! Wow, this is quite a big one, thanks. I am fine with adding the local strategy, even if at this point it'd make the "alone" one obsolete: just use the local with only one entry. I'd probably need to also update the README (to deprecate the alone
method) and probably issue a warning a start time ("You're using a deprecated authentication method, please blah blah"). Also, I need to get my head around all the work that you have done about the baseUrl and see if there's some drawbacks you didn't see... do you mind explain the rationale behind it?
I think I will need to merge this PR on a development branch (cherry picking the commits, maybe) and start the deprecation of the alone
strategy.
Will keep in touch!
The baseUrl stuff I changed on my fork was done so that I can put jingo into a subpath (e.g. /documentation/). It works for me now but I probably have to check again carefully if I missing a spot.
The best way is probably to generate relative urls in the generated html instead of static ones. though.
I didn't noticed that I created a pull request from master so I corrected this in #76.
I needed a intranet installation that allowed login of different users (to track who changed what) so I added a "local" authentication method which is essentially the same as as alone but with an array of accounts.
Maybe this is useful for others too.