File Upload Support - Githubissues

czenzel commented 8 years ago

I started to use Jingo and noticed that there was no File Upload support. I tried implementing a simple file upload solution for Jingo and placed it in a fork of the software which can be found on GitHub:

https://github.com/czenzel/jingo

I didn't want to make a full pull request yet as I am still testing this myself and there are some minor bugs in my code.

Let me know if this is something you want me to work with further or if you want to add it into Jingo.

The only thing is that you must create an uploads directory within the repository root for it to create uploads and serve them statically properly. This was to help with separating it from the actual content.

Thanks, Chris Zenzel

bradoyler commented 8 years ago

:+1:

claudioc commented 8 years ago

Hi @czenzel,

the implementation seems fine to me (but maybe I'd try to create the uploads directory from jingo itself?).

As integrating this feature in Jingo, I am a bit concerned. My idea with Jingo has been from the very beginning to provide not a full CMS, but more a simple "editor and viewer" for a document repository. Uploading files (or, in general, assets) it's a very simple issue only at first sight. Once you start adding that feature, you'll soon find other people asking for:

support to edit or remove an uploaded file (a file manager, that is)
the ability to choose a file or asset from the one you already have (file picker)
the ability for jingo to render the assets in a smart way (a video... an mp3... an image)
maybe the ability to provide "play on demand" only, if I am opening a page from mobile and I don't want to download the asset right away (because it could be too big)

What do you think?

aruizca commented 8 years ago

+1 for this

czenzel commented 8 years ago

Hi @claudioc , I do agree. The reason I choose this project is because it was very simple and provided a great way to start documenting things on the go.

The reason I implemented it was because I needed a simple way to keep weather documents with my wiki such as PDFs and diagrams. Just needed a simple way to keep snippets from the web as well.

I will see if I can work on it a bit further to see were it takes me. I can see implementing a file manager and automatic directory creation.

In terms of the videos and file viewers it would take me a while to see what is available. I am willing to work on it as time allows and keep it separate until we get something very concrete.

aruizca commented 8 years ago

Hi @claudioc, I am working on several improvements for this wiki engine because it suits our needs nicely. I agree with @czenzel that this is a must have feature if you have none-techies users as well. I am working with his fork changes to enable file upload, but also working on a file browser that allows you to see the files you have there and how to reference them from your markdown file. I have had some problems with @czenzel fork but I hope I can short them out soon. Cheers!

almereyda commented 8 years ago

I feel this discussion should circle around #63 and https://github.com/claudioc/jingo/pull/111#issuecomment-164245083

Because there are even plural storage backends imaginable (fs/git,IPFS,S3,S3-compatible,...) and due to the concerns mentioned above, this is probably not a core feature to enable self-contained wikis, favourably compatible with Gollum, Realms, gitit, Instiki et al.

In federated wiki, we are using a threefold storage abstraction.

claudioc / jingo

File Upload Support #98