Fixed garbled characters in utf-8 file names

claudiodangelis / qrcp

:zap: Transfer files over wifi from your computer to your mobile device by scanning a QR code without leaving the terminal.

https://qrcp.sh

MIT License

9.96k stars 529 forks source link

Fixed garbled characters in utf-8 file names #253

Closed top-bettercode closed 8 months ago

top-bettercode commented 1 year ago

Fixed garbled file names when send file

claudiodangelis commented 1 year ago

Ah, interesting! I will review this in a few days, possibly a week, and will merge it along with other changes for the new release. Thanks for taking the time of working on this!

claudiodangelis commented 1 year ago

Hi, thanks for your contribution, however, there are a few things which don't look too much ok:

go.mod and go.sum should be checked into the repository, not sure why you deleted them and gitignore'd them. See: https://github.com/golang/go/wiki/Modules#should-i-commit-my-gosum-file-as-well-as-my-gomod-file
proposed tests are not really ensuring the code is working as expected