search

claudiopro / react-fiber-vs-stack-demo

⚡️ React Fiber vs Stack Demo
https://claudiopro.github.io/react-fiber-vs-stack-demo
MIT License
146 stars 45 forks source link

Fiber demo does not increment the number inside the circles #3

Open miguel550 opened 7 years ago

miguel550 commented 7 years ago

The number inside the circles is fixed to 0. It should increment just like the Stack version demo.

claudiopro commented 7 years ago

Hi @miguel550 thanks for reporting this. Do you see this by installing latest dependencies? I can't repro on the github hosted app https://claudiopro.github.io/react-fiber-vs-stack-demo/

miguel550 commented 7 years ago

It's happening to the Fiber version in Chrome Version 61.0.3163.100 (Official Build) (64-bit) for Windows 10 using the github hosted app. In Microsoft Edge seems to work.

Denhai commented 6 years ago

Hmm, numbers increment on Safari 11.0.2 but not Chrome

jsobell commented 6 years ago

Same issue with Firefox

ryansolid commented 5 years ago

I was able to reproduce this quite easily by CPU throttling in chrome. On my computer it works properly incrementing the numbers until I apply CPU throttling. I think Fiber is just optimizing out the number incrementing in some scenarios. I did a similar test of Stencils version of the test and I saw a form of tearing where some numbers updated separately from others. In another example from a different framework under cpu throttling I saw the numbers update but it visibly stall like the stack version, even though it was as fast as fiber in normal operation.