search

claudiopro / react-fiber-vs-stack-demo

⚡️ React Fiber vs Stack Demo
https://claudiopro.github.io/react-fiber-vs-stack-demo
MIT License
142 stars 45 forks source link

feature request: add a checkbox to optionally increase seconds on every frame #5

Open Alexander-Taran opened 6 years ago

Alexander-Taran commented 6 years ago

Somebody saw your demo and created a repro using Aurelia http://aurelia-thousand-nodes.bigopon.surge.sh/ and here is the repo https://github.com/bigopon/aurelia-thousand-nodes

but with values in nodes updating only each second there is no way to compare. Both implementations (react with fiber and aurelia) perform @ 60fps.

But if updates to seconds happen on every frame - things slow down a bit.

Could you modify your demo to include the checkbox that when checked eliminates the interval and increases seconds on every frame?

ryansolid commented 5 years ago

I recommend applying CPU throttling in the Chrome Debugger Menu if you want to understand the difference of what is happening.

On my computer Aurelia stalls out as the numbers update under load, whereas Fiber is smooth but decides not to increment the numbers in some scenarios.

See if its the same for you. I think incremental rendering still has a bit of a ways to go.