search

claudiosanches / woocommerce-payment-discounts

Adds discounts for specific payment methods in WooCommerce.
http://wordpress.org/extend/plugins/woocommerce-payment-discounts/
31 stars 10 forks source link

length of coupon name causes layout issues #35

Open extrapixel opened 7 years ago

extrapixel commented 7 years ago

Most themes aren't prepared for super long coupon names. On small resolutions prices disappear off-screen and can't be scrolled to. On mobile, this results in prices / totals not being visible at all without a way to make it visible.

Example: Storefront screen shot 2017-04-22 at 01 46 49

Strictly speaking, this is a theme issue and can be solved by custom CSS.

However, also for usability, I'd prefer something that is very short and human readable. E.g. "3% BACS". Using the _woocommerce_cart_totals_couponlabel filter maybe?

A quick solution would be to use "-" instead of "_" so the browser can break the line.

Wegerich commented 7 years ago

capture I am having the same issue, but for me it is overlapping the "popular products widget".

I love the use of coupons but agree that I would like - instead of _

lotuzwine commented 7 years ago

There is a major breach on this pluggin. You can get this cupom code and apply to any payment method. I dont think this should be allowed. I really should search for an alternative to this pluggin.

extrapixel commented 7 years ago

@lotuzwine I've thought the same at first. But try it.

lotuzwine commented 7 years ago

I actually tried and applied the discount using a credit card payment method, which should not have any discount at all.

extrapixel commented 7 years ago

I've just tried it (again - it was the first i tried with the new version). While it says "coupon applied" at the messages, it doesn't actually apply it. Try it again and pay attention to the totals.

The actual issue is the message "coupon applied" appearing. It should not. But nobody can cheat (not on my installation at least).

Wegerich commented 7 years ago

I can confirm that the coupon code "successfully" applies to other payment methods but it gives a discount of zero. Please create a separate thread for this as it is not related to the topic.

lotuzwine commented 7 years ago

Thread created.

sarinalustosa commented 4 years ago

Does someone was able to solve this problem? I'm having the same problem.

extrapixel commented 3 years ago

@claudiosanches why don't you just change the '_' character to '-' ?

such a low hanging fruit. if you care, just do it. It has been 3 years... it's time!