Redone debian packaging in a more standardised way

claudyus / LXC-Web-Panel

LXC Web Panel improved for lxc 1.0+

http://claudyus.github.io/LXC-Web-Panel/

Other

221 stars 68 forks source link

Redone debian packaging in a more standardised way #9

Closed robvdl closed 10 years ago

robvdl commented 10 years ago

package is now built using "dpkg-buildpackage"
Makefile gets in the way of dpkg-buildpackage as it tries to execute make commands, so made it a fabfile.py instead
debian/changelog is automatically generated from git tag (to keep versioning the same as what it was before)
init script is done the "debian way" just naming it debian/lwp.init is enough (it gets installed/uninstalled by dh_installinit)
postinst and prerem scripts no longer needed (handled by dh_installinit)
copy built package into gh-pages directory as before

There is one TODO note, still need to handle the package signing

robvdl commented 10 years ago

I wouldn't merge this just yet, there is still something not quite right with the packages it builds (the daemon starts, but web app isn't running), I am looking into it.

At the moment, lwp doesn't seem to have any logging either, which doesn't help find the issue. One way to add logging quickly and easily, is to use upstart, since upstart can automatically capture output and log it to /var/log/upstart/lwp.log

However, I have held off switching to upstart and trying not to change things too much.

robvdl commented 10 years ago

I found the issue, it's fixed now

claudyus commented 10 years ago

Hi Rob, I just pick your commits and adds some little thinks anyway your work is great! I noticed that you didn't copy the lwp.example.conf file in /etc/lwp, there some side effect copying it?

I don't know the debian packaging system so do you see some problem in this https://github.com/claudyus/LXC-Web-Panel/commit/1d2a4755286a5810cc6be7a7b23cddb335fcbff7 ?

robvdl commented 10 years ago

That looks fine, yes

robvdl commented 10 years ago

I've just done a new commit in my remote that includes all your changes and also a missing semi colon I found in the fabfile.py and a spelling mistake.

I will have a look if I can get the package signing working again (I think it's either the -uc -us argument needs to be removed, or both).

robvdl commented 10 years ago

I have re-implemented the package signing part, seemed dpkg-sig was still the way to go.

I also deleted the .changes file left during build to keep the parent directory clean.

claudyus commented 10 years ago

Thanks rovdl, I merge your work initial work with few changes. I didn't notice that you provide also a solution for .changes file and package sign, we done the same work at the same time :D

robvdl commented 10 years ago

Sorry about that, I also created one more commit in a separate branch "upstart". I didn't put this to the main branch I was working on though, because it does make it specific to Ubuntu. But it does simplify the daemon script a lot, and you get automatic logging if the daemon crashes you get a traceback in /var/log/upstart/lwp.log which can be handy for debugging.

https://github.com/robvdl/LXC-Web-Panel/blob/upstart/debian/lwp.upstart