search

claui / homebrew-textmate

External Homebrew command and repo for TextMate bundles
14 stars 5 forks source link

Add Elixir.tmbundle #1

Closed jish closed 7 years ago

jish commented 7 years ago

I have never created a Homebrew Cask before so I'm not sure if this is correct or not. I used some examples in this repo and I also used the "Adding a Cask" documentation.

Please let me know what I should change or how I should test this to make sure it works properly.

claui commented 7 years ago

Great work @jish, and even more so for a first Cask!

The best option for Casks is to always pin to a version, or release; this allows users to benefit from (and ultimately trust) the SHA sums. If we’re dealing with a Cask that must use version :latest (e. g. when the upstream project does not define releases and version numbers), then the Cask needssha256 :no_check, which you did correctly. 👍

As soon as the It seems the TextMate bundle source 'Elixir.tmbundle' is not there error is fixed, there’s nothing stopping us from merging!

jish commented 7 years ago

Thanks for the help, I updated the tmbundle line.

claui commented 7 years ago

Merged.