claui / homebrew-textmate

External Homebrew command and repo for TextMate bundles
14 stars 5 forks source link

Testing Fork #3

Open ryanfitzer opened 7 years ago

ryanfitzer commented 7 years ago

I've created a new Cask and want to test it before submitting a PR. The instructions say:

For your personal fork, use /homebrew-textmate instead of …-cask

Does this mean overwriting BREW_TM_HOME? Can you give an example of how to structure that command?

Thanks for putting this together!

claui commented 7 years ago

Welcome @ryanfitzer, and thanks for contributing!

For your personal fork, use /homebrew-textmate instead of …-cask Does this mean overwriting BREW_TM_HOME? Can you give an example of how to structure that command?

This sentence is misleading and unnecessary. I was only referring to what your repo should be called on GitHub. (In your case, ryanfitzer/homebrew-textmate.) The command in the Pushing section of Caskroom’s instructions already takes care of this.

Specifically, I didn’t mean to refer to testing, or to anything on your local machine.

Regarding testing: you should be fine with just working on the tap directly, and from there just follow Caskroom’s instructions at Testing your new Cask with the few modifications given in our README.

Does this mean overwriting BREW_TM_HOME?

No, nothing of that should be necessary.

The easiest method is to do everything directly in your local, Homebrew-managed tap directory.

Assuming that you have done brew tap claui/textmate once, just go to /usr/local/Homebrew/Library/Taps/claui/homebrew-textmate and work on that repo. From there, simply follow the Caskroom instructions.

(Specifically, I don’t think maintaining a local clone, e. g. under your home directory, is worth the hassle. As all the brew commands only look at the taps under /usr/local/…, you’d have to take care of syncing your custom repo with the tap all the time. It’s definitely possible; however for testing, it’s only pain and confusion.)

Can you give an example of how to structure that command

Have you tried working directly in the tap directory? Is there a specific step in Testing Your New Cask where you are experiencing issues?

claui commented 7 years ago

(By the way, I have updated the README to lose that less-than-helpful sentence.)