claunia / plist-cil

C#/.NET parser for Apple and GnuStep Property List (aka plist), based on Java's dd-plist
Other
54 stars 17 forks source link

Minor enhancements to plist-cil #2

Closed qmfrederik closed 8 years ago

qmfrederik commented 8 years ago

Hi,

I used plist-cil and encoutered some minor issues; so here is a pull request which should address them:

claunia commented 8 years ago

Hi @qmfrederik. Everything seems good. Can you please add a test case for the duplicate UID case?

claunia commented 8 years ago

@3breadt do you think dd-plist can benefit from these enhancements?

qmfrederik commented 8 years ago

Hi @claunia ,

Cool, thx. I'll try to send you a PR with a unit test; if you don't get one, feel free to ping me :-)

3breadt commented 8 years ago

Some of the improvements really make sense and would benefit dd-plist. But I am not sure whether equivalent arrays really should be saved multiple times. Is that also just for binary compatibility with the plists produced by Apple's code?