search

claunia / plist-cil

C#/.NET parser for Apple and GnuStep Property List (aka plist), based on Java's dd-plist
Other
56 stars 17 forks source link

Support NETStandard 1.3, 1.6 #23

Closed qmfrederik closed 7 years ago

qmfrederik commented 7 years ago

This PR adds support for NETStandard 1.3 and 1.6; the current version of plist-cil supports NETCoreApp which is slightly different.

It also adds net45 as an explicit target (because the reference assemblies for net45 are structured differently ).

With these 4 PRs, I think I've captured all of the changes in our fork relative to claunia/plist-cil. So if they get merged, I think we can take CoreCompat.plist-cil offline. Cool!

claunia commented 7 years ago

@qmfrederik I can't currently upgrade the nuget package and will take several weeks before I'm able to, sorry :(

qmfrederik commented 7 years ago

@claunia Thanks! I'll run our unit tests against vanilla plist-cil; if they all come back green I think we're good to remove the CoreCompat variant!

qmfrederik commented 7 years ago

@claunia I checked, all our tests seem to pass with plist-cil. I've marked CoreCompat.plist-cil as hidden on NuGet (you cannot actually remove anything on NuGet).

Thanks!

claunia commented 7 years ago

@qmfrederik happy to hear!