Closed qmfrederik closed 5 years ago
I've spent some time today figuring out why the BinaryPropertyListWriter was generating slightly different data from what I expected.
BinaryPropertyListWriter
To figure that out, did some debugging tricks like:
EqualityComparer
AssignID
BinaryPropertyListParser
In the end, my life would be easier if:
DoParse
This PR makes some of the methods protected and adds a new constructor, just enough so that I can actually do that.
Hopefully this is OK with you.
The build failure is addressed by #52
I've spent some time today figuring out why the
BinaryPropertyListWriter
was generating slightly different data from what I expected.To figure that out, did some debugging tricks like:
EqualityComparer
s which are passed to theBinaryPropertyListWriter
AssignID
BinaryPropertyListParser
to get the index, offset and summary of all values in the binary property list,In the end, my life would be easier if:
BinaryPropertyListParser
andBinaryPropertyListWriter
and override methods likeDoParse
.BinaryPropertyListWriter
when it's being created.This PR makes some of the methods protected and adds a new constructor, just enough so that I can actually do that.
Hopefully this is OK with you.