Closed liyuanqiu closed 5 years ago
Heya, thanks for this. I guess we can add React as a peer dependency and bundle with babel.
Since this package has used webpack, externals
option in webpack.config.js may be useful.
https://webpack.js.org/configuration/externals/
Move react
and some other dependencies into peerDependencies
and add them to the externals
configuration option.
React and ReactDOM should really be moved into peer dependencies, not only does it blow up the bundle size but also inserts development builds of these into pages
Just noting that this has the help wanted
label all, feel free to submit a PR if it's an issue for you. Not sure when either myself or @claus will be able to get to it.
Resolved by #18
https://github.com/claus/react-dat-gui/blob/master/build/react-dat-gui.js
This file in the NPM package is too large:
Maybe you can add
src
directory into NPM package, then I can use it like this:Or just do not
webpack
it while build, only compiles it bybabel
. Users really don't need your dependencies likeReact
.I really appreciate you to create this wonderful tool, which helps me in my work. But I have no more time to contribute code, so if you have a portal to donate, I'd like to do so.