search

clausbroch / node-red-gfconnect

A Node-RED Project for connecting with Grainfather Connect G30 brewing system
https://www.norgesvej12a.dk/husbryg/category/equipment-and-integrations/grainfather-integration/
MIT License
19 stars 6 forks source link

On brewfather side i cant upload recepies to the gf from the pie, the error is #13

Closed hwvvse closed 4 years ago

hwvvse commented 4 years ago

"TypeError cannot read property 'length' of undefined" both on "start session" And if i try to upload a batch file from brewfather it says its not an brewfather batch file...

clausbroch commented 4 years ago

And if i try to upload a batch file from brewfather it says its not an brewfather batch file...

Could you attach the file ?

hwvvse commented 4 years ago

sure, here is the recepie Brewfather_RECIPE_Fagelkvittergf_20200810.txt

clausbroch commented 4 years ago

sure, here is the recepie Brewfather_RECIPE_Fagelkvittergf_20200810.txt

Recipe JSON files are not supported. It has to be a Batch JSON file. The recipe JSON doesn't include all the calculations needed for transfering the brew session to the controller.

hwvvse commented 4 years ago

ok, thats secondary tho, the button "start session" gives the error above.... but its logd in and i can see the recepie in there...

clausbroch commented 4 years ago

ok, thats secondary tho, the button "start session" gives the error above.... but its logd in and i can see the recepie in there...

I have managed to reproduce the error you are experiencing. Apparently some batch data is missing from Brewfather, but I need to look a bit deeper into this to find the root cause.

clausbroch commented 4 years ago

I have now found the cause for this error.

It turns out that the batch data returned from Brewfather is indeed missing some parameters used for the boil additions. However this only seems to happen if you have not made any adjustments to the batch after it was initiated from the original recipe. So if you tweak the recipe, e.g. adjust for hops AA. You can also work around the problem if you change the batch status from "planning" to "brewing" in Brewfather prior to loading the batch into GF Connect

hwvvse commented 4 years ago

ok, sorry for the late update... did a clone on a recipe ive got, works...