clausecker / freefare

Go bindings for the libfreefare
GNU Lesser General Public License v3.0
18 stars 3 forks source link

Key derivation support #4

Closed graynk closed 4 years ago

graynk commented 5 years ago

I'm looking at this example of libfreefare and I can't find any function for mifare_ultralightc_set_key in UltralightTag, nor is there a MifareKeyDeriver. Are there any plans to add the support for this? Here's the commit with most of the changes.

clausecker commented 5 years ago

This function is not part of any libfreefare release. In fact, they haven't made a release since 0.4.0 which is the release this library has been written against. If you can convince the library maintainers to perhaps make a new release, I can start adding the new features to the library.

clausecker commented 4 years ago

Addressed by PR #8 I believe. @graynk, can you confirm?

graynk commented 4 years ago

That is correct, this PR adds a wrapper on MifareKeyDeriver and adds needed functions to UltralightTag

clausecker commented 4 years ago

I think we can close this then.