search

clausecker / freefare

Go bindings for the libfreefare
GNU Lesser General Public License v3.0
18 stars 3 forks source link

ReadPage returns zeroed array in ultralight.go #6

Closed graynk closed 4 years ago

graynk commented 5 years ago

https://github.com/fuzxxl/freefare/blob/0db9bd4463f361189042156563572f0517fa7b9c/0.3/freefare/ultralight.go#L63-L68

It should be return data, nil here. I could keep track of any issues that may arise as I work my way through my project that uses this wrapper, and then make a PR with all the fixes I end up with, so as not to spam with any more issues, if that's okay with you.

clausecker commented 5 years ago

Thank you for reporting this issue! Making one huge pull request is probably a good idea. I do not really work on this project anymore, but I'm happy to accept reasonable pull requests.

clausecker commented 4 years ago

Did you end up finishing your project? If yes, I would definitely still appreciate a pull request.

graynk commented 4 years ago

It kind of got stuck in the middle because management didn't know if they wanted to use ultralight tags or not and then I changed workplaces, so I don't actually work with hardware anymore. But I did end up fixing a few bugs and used pretty much all of Ultralight's functionality in my prototype complete with key derivation, so I will try to dig it up and make a PR over the weekend!

clausecker commented 4 years ago

Thanks a lot! Your help is very valuable.