clausreinke / typescript-tools

(repo no longer active) Tools related to the TypeScript language
Apache License 2.0
266 stars 29 forks source link

Support TypeScript 0.9.0.1 #5

Closed Truebase-com closed 10 years ago

Truebase-com commented 11 years ago

Any chance of this happening?

clausreinke commented 11 years ago

0.9.x - definitely (want the new features:-). Just don't know when, yet. Current 0.9 versions still seem to have serious issues (performance, mis-compilations, etc), according to their issue tracker. Waiting for things to settle a bit more.

Then timing depends on how much the language services have changed. Do you need this urgently?

Truebase-com commented 11 years ago

Wouldn't say I need it urgently. I believe 0.9.0.1 fixed most of the mis-compilation issues you speak of (I've got a 15k line code base that compiles just fine). Performance is still noticeably slower than 0.8

jlujan commented 10 years ago

Added a pull request that at least compiles. The example editor does not function though.

https://github.com/jviereck/TypeScriptServiceExample/pull/2

jlujan commented 10 years ago

Oops. Commented on the wrong project. Guess it is still relevant.

clausreinke commented 10 years ago

Oops. Commented on the wrong project. Guess it is still relevant.

Yes, I noticed that;-) Did you find a better conversion strategy than "try { compile } catch() { fix }"?

jlujan commented 10 years ago

No, brute forced through the errors. A lot changed and it isn't clear. There are also parts that throw NotImplemented as in ScriptSnapshot.getTextChangeRangeSinceVersion. Here I just return a range to cover the full content. Seems like LanguageService is not complete in 0.9.0.1.

clausreinke commented 10 years ago

There is now a temporary branch testing_v0.9 with a TSv0.9.1 compatible version. It is still in a branch because upgrading turned out to involve a partial rewrite, so there is lots of potential for bugs, etc. Please test and let me know how it goes.

clausreinke commented 10 years ago

As of https://github.com/clausreinke/typescript-tools/commit/ba005253af9175bf8086f60294273b397d2537bd , testing_v0.9 has been merged into master. See file CHANGES.txt for change log.