eliocamp commented 6 years ago

Adds last_plot() to default value of plot.

Closes #9

clauswilke commented 6 years ago

I committed some changes to the package to make sure it builds on Travis. Could you rebase/merge to see if your PR passes the checks? I assume last_plot() needs a ggplot2:: in front or an appropriate @importFrom statement in the roxygen block.

eliocamp commented 6 years ago

I'm not good at dependencies and all that, but I believe that since ggplot2 is listed in "depends", it's not needed. But I added just in case. devtools::check() passes on my machine :)

codecov-io commented 6 years ago

Codecov Report

Merging #10 into master will decrease coverage by 1.82%. The diff coverage is 0%.

@@            Coverage Diff             @@
##           master      #10      +/-   ##
==========================================
- Coverage   35.35%   33.53%   -1.83%     
==========================================
  Files           6        6              
  Lines         181      167      -14     
==========================================
- Hits           64       56       -8     
+ Misses        117      111       -6

Impacted Files	Coverage Δ
R/edit_colors.R	`95.23% <ø> (-1.32%)`	:arrow_down:
R/cvd_grid.R	`0% <0%> (ø)`	:arrow_up:
R/view_cvd.R	`0% <0%> (ø)`	:arrow_up:
R/scales.R	`0% <0%> (ø)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cc54c8a...0e3d658. Read the comment docs.

clauswilke commented 6 years ago

Yes, you're right. I should probably change that. In any case, the travis build passed, so I'm merging.

clauswilke commented 6 years ago

Thanks!

clauswilke / colorblindr

Change default value of `plot` #10

Codecov Report