Closed wckdouglas closed 6 years ago
Merging #4 into master will decrease coverage by
0.06%
. The diff coverage is0%
.
@@ Coverage Diff @@
## master #4 +/- ##
==========================================
- Coverage 16.15% 16.08% -0.07%
==========================================
Files 9 9
Lines 489 491 +2
==========================================
Hits 79 79
- Misses 410 412 +2
Impacted Files | Coverage Δ | |
---|---|---|
R/HCL_color_picker.R | 0% <0%> (ø) |
:arrow_up: |
R/scales.R | 0% <0%> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update a19bd16...29b2e07. Read the comment docs.
The error message ("Hex color already in color list") seems wrong now. Maybe write "Hex color incomplete or already in color list"?
Actually, or better, write two separate need
statements, as shown here:
https://shiny.rstudio.com/reference/shiny/latest/validate.html (scroll down)
Fixing a bug on allowing empty color selection