search

clauswilke / dataviz

A book covering the fundamentals of data visualization
https://clauswilke.com/dataviz
Other
3.2k stars 701 forks source link

typos in visualizing_uncertainty.Rmd #83

Closed tjmahr closed 5 years ago

tjmahr commented 5 years ago

fixed typos of "trial", "deterministic", "minimize" moved a comma to after an "e.g." changed an "e.g." to an "i.e."

I assign the copyright of this contribution to Claus O. Wilke.

clauswilke commented 5 years ago

Thanks! Would you mind amending your commit comment to include "I assign the copyright of this contribution to Claus O. Wilke", as described here? I try to be consistent about this, even if we're talking about fixes for minor typos.

tjmahr commented 5 years ago

Done. Thanks to this guide https://help.github.com/articles/changing-a-commit-message/#amending-older-or-multiple-commit-messages

clauswilke commented 5 years ago

Thanks. Do you use RStudio git integration? It has a convenient "amend previous commit" button. (And generally works great, except when it crashes RStudio once every 20 commits or so...)

tjmahr commented 5 years ago

I made my original edits through GitHub so I assumed I had to use fancier command-line stuff to fix a message that already was in a pull request on GitHub. But yeah, 95% of my git work is through the RStudio integration 😄

By the way, glad to see you getting mileage from the chocolate ratings dataset!