search

claviska / SimpleImage

A PHP class that makes working with images and GD as simple as possible.
MIT License
1.38k stars 382 forks source link

RFC: SimpleImage 4.0 #284

Open claviska opened 3 years ago

claviska commented 3 years ago

I'm considering a release that would drop support for PHP 5.x since it's no longer supported. This will be a breaking change, so the version will move to 4.0. There are a handful of PHP 7-only things that this will solve (e.g. #283), but it will also let use modern syntax and remove some legacy code.

This issue is for planning and discussion around what we can improve/remove in the existing code base. No new features will be accepted for 4.0, and will instead be reserved for 4.1 (or later). API changes that have been planned or make sense will be considered, but should be kept to a minimal.

That said, I'm opening the floor to discussions. If you plan on submitting a PR for this release, please post here first to coordinate so that everyone is on the same page and we can make sure the work you're doing is in scope.

claviska commented 3 years ago

@maPer77 — I believe there were some breaking changes you were thinking of introducing recently. Now would be a good time if you still think it's a good idea.

maPer77 commented 3 years ago

@claviska Do you mean dividing functions into files with "TRAIT"?

claviska commented 3 years ago

Trait is more intended for reuse, so while it's possible, I don't think it's suitable for restructuring. It would probably be more "correct" to split each method into generic functions/separate files and keep the API methods in the main file.

I'm not opposed to restructuring for 4.0, but it's also not a requirement at this time (it could be done later without breaking changes).