search

claviska / SimpleImage

A PHP class that makes working with images and GD as simple as possible.
MIT License
1.38k stars 382 forks source link

Add reset and hasImage methods and make generate public #339

Closed thisispiers closed 4 months ago

claviska commented 4 months ago

Did you mean to publish this upstream? I'm closing this because there's no information asking or explaining what these changes are useful for. If these changes are justified and accepted, the readme also needs to be updated.

claviska commented 4 months ago

Just to follow up, I can see where reset() might be useful, but it's not clear why generate() needs to be public.

thisispiers commented 4 months ago

Getting the raw image data and mime type is needed to generate a checksum, for instance, or save to S3 via the AWS SDK.

Making generate() public removes the need to decode toString() back into the array that generate() already returns.

claviska commented 4 months ago

Thanks, that's a pretty good use case. Would you mind updating the docs to reflect the new public methods?