search

clawfire / covid19-passbook-generator

A simple PWA to scan your EU digital COVID Certificate and generate a passbook from it
https://covid19passbook.netlify.app/
Other
128 stars 24 forks source link

[feature request] support importing PDFs #31

Closed grischard closed 3 years ago

grischard commented 3 years ago

Is your feature request related to a problem? Please describe. In Luxembourg, you download your certificate as a PDF. You can upload a screenshot, but importing it in the app directly would be easier.

Describe the solution you'd like Automatic rasterisation of PDFs.

Additional context PDFs that contain a huge JPEG are actually supported on mobile Safari. This is not the case for the EU covid codes, so the upload button only supports image/* for now.

See also #11 for the issue to support uploading images - it has some context on PDFs

github-actions[bot] commented 3 years ago

This issue seems to be a little bit old and no ones seems to be able to help 😕. Or waiting for more informations from the reporter ⏳. If no new activity, It will be closed in 25 days

clawfire commented 3 years ago

The thing is I'm not sure the picture import détection will work well ith so many noise. Need some testing

biou commented 3 years ago

we would need a component to crop the QR code from the whole PDF.

Le jeu. 22 juil. 2021 à 13:33, Thibault Milan @.***> a écrit :

The thing is I'm not sure the picture import détection will work well ith so many noise. Need some testing

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/clawfire/covid19-passbook-generator/issues/31#issuecomment-884843732, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAKHHWDQN7ZF75LZAIBPLZDTY76YZANCNFSM47VO7L7Q .

-- -- Alain

clawfire commented 3 years ago

Yep, that's sounds a bit difficult for end users :( Need to try to

  1. make a quality screenshot from the entire pdf
  2. import it in the app and see how it behave
github-actions[bot] commented 3 years ago

This issue seems to be a little bit old and no ones seems to be able to help 😕. Or waiting for more informations from the reporter ⏳. If no new activity, It will be closed in 5 days

clawfire commented 3 years ago

what do you think if we do a tutorial on how to make the screenshot and import it ?

github-actions[bot] commented 3 years ago

Sorry this issue cannot be solved 😔 . We may not have enough workforce to handle it. Please reopen it if you want to add something new.