clawfire / covid19-passbook-generator

A simple PWA to scan your EU digital COVID Certificate and generate a passbook from it
https://covid19passbook.netlify.app/
Other
128 stars 24 forks source link

[BUG] Broken signing chain #390

Open dateacha opened 2 years ago

dateacha commented 2 years ago

Contact Details

dateacha@gmail.com

What happened?

I have no problem scanning the QR code (recovery certificate Luxembourg) but when I want to add it to the Walltet I get the following error message: Safari cannot download this file. Tried on an iPhone 13 as well as on iPad Air 5 with latest iPadOS. (the vaccination certificate a couple months worked out of the box though.)

What browsers are you seeing the problem on?

Safari

Are you browsing using

an iPhone

Anything else?

Also trieds the method importing a photo of the QR code out of the photo library, same result, app recognizes code but can't transfer it into the wallet.

github-actions[bot] commented 2 years ago

Hey there šŸ‘‹šŸ¼ Thanks for your first issue. This is an automated message but a real human will handle your issue very shortly.

dateacha commented 2 years ago

I'd like to add that I deactivated all kinds of blockers as I hoped that would help, unfortunately it didn't make a difference.

AlainVagner commented 2 years ago

Hi! With iOS 15, you can now add your certificate directly to your Wallet as described here: https://support.apple.com/en-gb/HT212752

Hope this helps!

dateacha commented 2 years ago

Hi,

nope, alrready had read this, is not possibele to transfer it from the Health app to the wallet, seems only to work with vaxx certificates but not with recovery certificates. :(

Thanx for your input however.

Regards, Marc

On 30 Jun 2022, at 11:26, Alain Vagner @.***> wrote:

Hi! With iOS 15, you can now add your certificate directly to your Wallet as described here: https://support.apple.com/en-gb/HT212752 https://support.apple.com/en-gb/HT212752 Hope this helps!

ā€” Reply to this email directly, view it on GitHub https://github.com/clawfire/covid19-passbook-generator/issues/390#issuecomment-1170982118, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZ3IPJ43QFHDAHMMA37I4WTVRVR3RANCNFSM52G6FF6A. You are receiving this because you authored the thread.

dateacha commented 2 years ago

For some odd reason I can add the pass to the health app, but not the Wallet as pictured here (personal data has been blanked out by myself). Normally this shoud say: Add to Wallet and Health Summary .

ra-pha commented 2 years ago

Just had the same problem as @dateacha with a recovery certificate. Can't download the pass from safari on a mobile device. With a laptop, the certificate.pkpass file is not readable by the Files app on mobile.

Was able to import into Health app only thanks to @AlainVagner 's comment, but not to Wallet (but that's an Apple problem, I'm aware of that).

ra-pha commented 2 years ago

Just to follow up: Tried https://covidpass.eu/en this morning and it works.

AlainVagner commented 2 years ago

We are investigating the technical issue.

dateacha commented 2 years ago

@ra-pha Thanx for offering an alternative, I'll use that as a backup if no fix can be offered by the original pass creator site. (I'd prefer using the original site, as it's the one officialy promoted by our government.)

@AlainVagner Thanx for looking into this problem and for dedicating your time.

JXGA commented 2 years ago

Iā€™m also seeing this issue with Ireland and N.Ireland passes.

aberus commented 2 years ago

Current generated passbooks are not valid, because are signed with old WWDC certificate. https://github.com/clawfire/covid19-passbook-signature/blob/main/handler.js#L57

Only the WWDC G4 certificate is valid for signing passes with certificates generated after the 27th of January, 2022.

clawfire commented 2 years ago

Thanks for the tips @aberus, will take a look at this.