search

clawoflight / aursec

Blockchain-based security layer for the AUR
Mozilla Public License 2.0
16 stars 2 forks source link

Shellcheck #27

Open Cody-Learner opened 6 years ago

Cody-Learner commented 6 years ago

Not sure how it works, but did you transpose some digits somewhere other than the comments in the aursec-parse-srcinfo script? Does shellcheck read the commented line in the script?

ie: In bin/aursec-parse-srcinfo line 26: if [[ "$val" =~ .::(.git(@|+http).|.svn(+http|://).|.bzr+http.|.hg+http.*) ]]; then ^-- SC1009: The mentioned parser error was in this regex grouping. ^-- SC1073: Couldn't parse this regex grouping. ^-- SC1072: Unexpected . Fix any mentioned problems and try again. -vs-

# shellcheck disable=SC1702,SC1703,SC1009

I tried rebuilding after today's update on the AUR and still can't.

clawoflight commented 6 years ago

Yeah, I don't understand why it doesn't work with the Arch package... As you can see, it worked in CI, where shellcheck is built from git: https://circleci.com/gh/clawoflight/aursec/307

Also, welcome to github! :)

clawoflight commented 6 years ago

These are multiple upstream bugs:

The disabling doesn't work per shellcheck/#1118, and the wiki post on SC1702 may be applicable as well.

Wait and see for the next upstream release, I guess... and