search

clawpack / amrclaw

AMR version of Clawpack
http://www.clawpack.org
BSD 3-Clause "New" or "Revised" License
26 stars 46 forks source link

Fix regression check gauges #151

Closed rjleveque closed 9 years ago

rjleveque commented 9 years ago

@mandli, could you check that this looks ok?

rjleveque commented 9 years ago

Travis is testing against the wrong version of clawutil. I'll do a PR on clawpack/clawpack to bring this up to date...

rjleveque commented 9 years ago

Well I merged clawpack/clawpack#76 and reran travis, and now I realize why @mandli didn't use the visclaw gaugetools for testing gauges -- that code is written to require matplotlib, not installed by travis.

This will take some more work... We should really have gauge tools for reading gauges that's independent of plotting routines, rather than having getgauge a method of ClawPlotData. We also talked about switching to using Pandas for gauges.

Maybe for now, revert to the old testing framework in clawpack/clawutil and save this for later?

rjleveque commented 9 years ago

I reverted clawutil, so closing this for now.